fix: fix unsigned int slicewindow error issue #25956

fix unsigned int slicewindow error issue #25956 Closes: #25956
pingcap · Jul 7, 2021 · 63309ac · 63309ac
1 parent 297a90d
commit 63309ac
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/executor/aggfuncs/func_max_min.go b/executor/aggfuncs/func_max_min.go
@@ -468,7 +468,7 @@ func (e *maxMin4UintSliding) UpdatePartialResult(sctx sessionctx.Context, rowsIn
 		if isNull {
 			continue
 		}
-		err = p.deque.Enqueue(uint64(i)+e.start, input)
+		err = p.deque.Enqueue(uint64(i)+e.start, uint64(input))
 		if err != nil {
 			return 0, err
 		}

diff --git a/executor/aggfuncs/func_max_min_test.go b/executor/aggfuncs/func_max_min_test.go
@@ -256,6 +256,12 @@ func (s *testSuite) TestMaxSlidingWindow(c *C) {
 			expect:        []string{"3", "3", "3"},
 			orderByExpect: []string{"1", "2", "3"},
 		},
+		{
+			rowType:       "int unsigned",
+			insertValue:   "(1), (3), (2)",
+			expect:        []string{"3", "3", "3"},
+			orderByExpect: []string{"1", "2", "3"},
+		},
 		{
 			rowType:       "float",
 			insertValue:   "(1.1), (3.3), (2.2)",