Skip to content

Commit

Permalink
statistics: add some key info in sync load timeout log (#49630) (#49636)
Browse files Browse the repository at this point in the history
close #49631
  • Loading branch information
ti-chi-bot authored Dec 22, 2023
1 parent dfedcc7 commit 7bcef4f
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions statistics/column.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ package statistics

import (
"math"
"strconv"

"github.com/pingcap/errors"
"github.com/pingcap/tidb/parser/model"
Expand Down Expand Up @@ -123,7 +122,9 @@ func (c *Column) IsInvalid(sctx sessionctx.Context, collPseudo bool) bool {
if c.IsLoadNeeded() && stmtctx != nil {
if stmtctx.StatsLoad.Timeout > 0 {
logutil.BgLogger().Warn("Hist for column should already be loaded as sync but not found.",
zap.String(strconv.FormatInt(c.Info.ID, 10), c.Info.Name.O))
zap.Int64("table_id", c.PhysicalID),
zap.Int64("column_id", c.Info.ID),
zap.String("column_name", c.Info.Name.O))
}
// In some tests, the c.Info is not set, so we add this check here.
if c.Info != nil {
Expand Down

0 comments on commit 7bcef4f

Please sign in to comment.