planner/core: infoschema tables should show global temp tables (#55379)

close #55375
pingcap · Aug 13, 2024 · bbe5266 · bbe5266
1 parent 3c30925
commit bbe5266
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/pkg/planner/core/memtable_infoschema_extractor.go b/pkg/planner/core/memtable_infoschema_extractor.go
@@ -428,7 +428,7 @@ func findNameAndAppendToTableMap(
 			return errors.Trace(err)
 		}
 		tblInfo := tbl.Meta()
-		if tblInfo.TempTableType != model.TempTableNone {
+		if tblInfo.TempTableType == model.TempTableLocal {
 			continue
 		}
 		tables[tblInfo.ID] = tblInfo
@@ -453,7 +453,7 @@ func findTablesByID(
 			continue
 		}
 		tblInfo := tbl.Meta()
-		if tblInfo.TempTableType != model.TempTableNone {
+		if tblInfo.TempTableType == model.TempTableLocal {
 			continue
 		}
 		if len(tableNames) > 0 {
@@ -514,7 +514,7 @@ func findTableAndSchemaByName(
 				return nil, nil, errors.Trace(err)
 			}
 			tblInfo := tbl.Meta()
-			if tblInfo.TempTableType != model.TempTableNone {
+			if tblInfo.TempTableType == model.TempTableLocal {
 				continue
 			}
 			tableMap[tblInfo.ID] = schemaAndTable{s, tblInfo}

diff --git a/tests/integrationtest/r/infoschema/infoschema.result b/tests/integrationtest/r/infoschema/infoschema.result
@@ -215,3 +215,14 @@ select count(1) from information_schema.statistics where table_name = 'temp_tabl
 count(1)
 0
 drop table temp_table;
+create global temporary table temp_table(a int, index idx(a)) on commit delete rows;
+select count(1) from information_schema.tables where table_schema = 'infoschema__infoschema';
+count(1)
+1
+select count(1) from information_schema.tables where table_name = 'temp_table';
+count(1)
+1
+select count(1) from information_schema.statistics where table_name = 'temp_table';
+count(1)
+1
+drop table temp_table;
diff --git a/tests/integrationtest/t/infoschema/infoschema.test b/tests/integrationtest/t/infoschema/infoschema.test
@@ -110,9 +110,14 @@ select * from INFORMATION_SCHEMA.KEY_COLUMN_USAGE where table_schema = 'db1' ord
 drop database db1;
 drop database db2;
 
-# TestTemporaryTableShouldNotAppear
+# TestLocalTemporaryTableShouldNotAppear
 create temporary table temp_table (a int, index idx(a));
 select count(1) from information_schema.tables where table_schema = 'infoschema__infoschema';
 select count(1) from information_schema.tables where table_name = 'temp_table';
 select count(1) from information_schema.statistics where table_name = 'temp_table';
 drop table temp_table;
+create global temporary table temp_table(a int, index idx(a)) on commit delete rows;
+select count(1) from information_schema.tables where table_schema = 'infoschema__infoschema';
+select count(1) from information_schema.tables where table_name = 'temp_table';
+select count(1) from information_schema.statistics where table_name = 'temp_table';
+drop table temp_table;