server: openSession instead set nil when changeUser (#33894) (#34427)

close #33892
pingcap · May 7, 2022 · be48447 · be48447
1 parent f604940
commit be48447
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/server/conn.go b/server/conn.go
@@ -2321,7 +2321,12 @@ func (cc *clientConn) handleChangeUser(ctx context.Context, data []byte) error {
 	if err := cc.ctx.Close(); err != nil {
 		logutil.Logger(ctx).Debug("close old context failed", zap.Error(err))
 	}
-	cc.ctx = nil
+	// session was closed by `ctx.Close` and should `openSession` explicitly to renew session.
+	// `openSession` won't run again in `openSessionAndDoAuth` because ctx is not nil.
+	err := cc.openSession()
+	if err != nil {
+		return err
+	}
 	if err := cc.openSessionAndDoAuth(pass, ""); err != nil {
 		return err
 	}