Skip to content

Commit

Permalink
fix global kill coroutine leak
Browse files Browse the repository at this point in the history
Signed-off-by: Ping Yu <yuping@pingcap.com>
  • Loading branch information
pingyu committed Aug 13, 2023
1 parent 92b5a67 commit e369611
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions executor/simple.go
Original file line number Diff line number Diff line change
Expand Up @@ -2617,6 +2617,7 @@ func killRemoteConn(ctx context.Context, sctx sessionctx.Context, gcid *globalco
err := errors.New("client returns nil response")
return err
}
resp.Close()

Check warning on line 2620 in executor/simple.go

View check run for this annotation

Codecov / codecov/patch

executor/simple.go#L2620

Added line #L2620 was not covered by tests

logutil.BgLogger().Info("Killed remote connection", zap.Uint64("serverID", gcid.ServerID),
zap.Uint64("conn", gcid.ToConnID()), zap.Bool("query", query))
Expand Down

0 comments on commit e369611

Please sign in to comment.