Skip to content

Commit

Permalink
address comment
Browse files Browse the repository at this point in the history
  • Loading branch information
xuyifangreeneyes authored and ti-chi-bot committed Jun 2, 2023
1 parent 4c1308f commit f86d638
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions util/ranger/ranger_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ func TestCompIndexMultiColDNF2(t *testing.T) {
}
}

func TestCompIndexMultiColDNF3(t *testing.T) {
func TestIssue41572(t *testing.T) {
store := testkit.CreateMockStore(t)

testKit := testkit.NewTestKit(t, store)
Expand All @@ -1023,7 +1023,7 @@ func TestCompIndexMultiColDNF3(t *testing.T) {
output[i].Result = testdata.ConvertRowsToStrings(testKit.MustQuery(tt).Rows())
})
testKit.MustQuery("explain " + tt).Check(testkit.Rows(output[i].Plan...))
testKit.MustQuery(tt).Check(testkit.Rows(output[i].Result...))
testKit.MustQuery(tt).Sort().Check(testkit.Rows(output[i].Result...))
}
}

Expand Down
2 changes: 1 addition & 1 deletion util/ranger/testdata/ranger_suite_in.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
]
},
{
"name": "TestCompIndexMultiColDNF3",
"name": "TestIssue41572",
"cases": [
"select * from t use index (idx) where ((a = 't' and b = 1) or (a = 't' and b = 2) or (a = 'w' and b = 0)) and c > 2",
"select * from t use index (idx) where ((a = 't' and b = 1) or (a = 't' and b = 2) or (a = 'w' and b = 0)) and d > 2"
Expand Down
2 changes: 1 addition & 1 deletion util/ranger/testdata/ranger_suite_out.json
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@
]
},
{
"Name": "TestCompIndexMultiColDNF3",
"Name": "TestIssue41572",
"Cases": [
{
"SQL": "select * from t use index (idx) where ((a = 't' and b = 1) or (a = 't' and b = 2) or (a = 'w' and b = 0)) and c > 2",
Expand Down

0 comments on commit f86d638

Please sign in to comment.