Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ID and NAME columns in TIDB_CLUSTER_INFO #13586

Closed
lonng opened this issue Nov 19, 2019 · 1 comment
Closed

Remove the ID and NAME columns in TIDB_CLUSTER_INFO #13586

lonng opened this issue Nov 19, 2019 · 1 comment
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lonng
Copy link
Contributor

lonng commented Nov 19, 2019

This issue is part of #13567.

We should remove the NAME and ID columns of TIDB_CLUSTER_INFO system table because they are not the real stable value for cluster topology according to

tidb/infoschema/tables.go

Line 1910 in ec2d6b7

name := fmt.Sprintf("%s-%d", tp, len(rows))
.
@lonng lonng added the type/enhancement The issue or PR belongs to an enhancement. label Nov 19, 2019
This was referenced Nov 19, 2019
Closed
Merged
@lonng
Copy link
Contributor Author

lonng commented Nov 19, 2019

Closed via #13587

@lonng lonng closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lonng