infoschema: remove the ID and NAME columns of TIDB_CLUSTER_INFO #13587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonng <heng@lonng.org>
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #13587 +/- ##
===========================================
Coverage 79.9494% 79.9494%
===========================================
Files 472 472
Lines 115817 115817
===========================================
Hits 92595 92595
Misses 15974 15974
Partials 7248 7248 |
|
/run-all-tests |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
lonng
added
status/LGT2
This was referenced Nov 19, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
Fix issue #13586
What is changed and how it works?
We should remove the
NAMEandIDcolumns ofTIDB_CLUSTER_INFOsystem table because they are not the real stable value for cluster topology according totidb/infoschema/tables.go
Line 1910 in ec2d6b7
Check List
Tests
Release note