Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrInvalidFieldSize error code is not 3013 on branch release-3.0 #13734

Closed
cyliu0 opened this issue Nov 26, 2019 · 3 comments
Closed

ErrInvalidFieldSize error code is not 3013 on branch release-3.0 #13734

cyliu0 opened this issue Nov 26, 2019 · 3 comments
Labels
type/bug The issue is confirmed as a bug.

Comments

@cyliu0
Copy link
Contributor

cyliu0 commented Nov 26, 2019

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    If possible, provide a recipe for reproducing the error.

According to pingcap/parser#534 , the error code should be 3013.

  1. What did you expect to see?
    On Master
mysql> create table t (a bit(0));
ERROR 3013 (HY000): Invalid size for column 'a'.

mysql> select tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v4.0.0-alpha-984-gacfc7be79
Git Commit Hash: acfc7be7941ed9f18d77009641ea77986de2ff1d
Git Branch: master
UTC Build Time: 2019-11-26 05:51:30
GoVersion: go version go1.13.1 darwin/amd64
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.00 sec)
  1. What did you see instead?
    On branch release-3.0
mysql> create table t (a bit(0));
ERROR 1105 (HY000): Invalid size for column 'a'.

mysql> select tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v3.0.5-87-gac4767a93
Git Commit Hash: ac4767a933497db9053a6ae3e818959d2ef80d71
Git Branch: release-3.0
UTC Build Time: 2019-11-26 05:49:58
GoVersion: go version go1.13.1 darwin/amd64
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.00 sec)
  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?
@cyliu0 cyliu0 added the type/bug The issue is confirmed as a bug. label Nov 26, 2019
@cyliu0
Copy link
Contributor Author

cyliu0 commented Nov 26, 2019

@tangenta Please check this issue.

@ghost
Copy link

ghost commented Jul 17, 2020

Confirming this has been fixed in master:

mysql> create table t (a bit(0));
ERROR 3013 (HY000): Invalid size for column 'a'.
mysql> select tidb_version()\G
*************************** 1. row ***************************
tidb_version(): Release Version: v4.0.0-beta.2-782-gb72e47e6d
Edition: Community
Git Commit Hash: b72e47e6db8863c08e47714391cf937b0f1c3269
Git Branch: master
UTC Build Time: 2020-07-15 01:26:06
GoVersion: go1.13
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
1 row in set (0.00 sec)

@ghost
Copy link

ghost commented Jul 17, 2020

I am going to close this issue now :-)

@ghost ghost closed this as completed Jul 17, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

1 participant