Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add a mysql error message #534

Merged
merged 2 commits into from
Sep 2, 2019

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Aug 30, 2019

What problem does this PR solve?

Add a MySQL error message for PR #530.

https://dev.mysql.com/doc/refman/8.0/en/server-error-reference.html

Error number: 3013; Symbol: ER_INVALID_FIELD_SIZE; SQLSTATE: HY000
Message: Invalid size for column '%s'.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #534 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   71.79%   71.76%   -0.03%     
==========================================
  Files          32       32              
  Lines        7800     7800              
==========================================
- Hits         5600     5598       -2     
- Misses       1673     1674       +1     
- Partials      527      528       +1
Impacted Files Coverage Δ
ast/ddl.go 80.44% <0%> (-0.13%) ⬇️
parser.go 70.58% <0%> (ø) ⬆️
misc.go 96.49% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4918e2...57bae4d. Read the comment docs.

@zier-one
Copy link
Contributor

zier-one commented Sep 2, 2019

LGTM
@kennytm PTAL

Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta merged commit 275a827 into pingcap:master Sep 2, 2019
tangenta pushed a commit to tangenta/parser that referenced this pull request Nov 8, 2019
tangenta pushed a commit to tangenta/parser that referenced this pull request Nov 8, 2019
tangenta pushed a commit to tangenta/parser that referenced this pull request Nov 8, 2019
tangenta pushed a commit that referenced this pull request Nov 11, 2019
tangenta pushed a commit that referenced this pull request Nov 11, 2019
tangenta pushed a commit that referenced this pull request Nov 11, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants