Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tics: test should check tidb_enable_change_multi_schema before changing multi schema #21549

Closed
AilinKid opened this issue Dec 8, 2020 · 3 comments
Labels
duplicate Issues or pull requests already exists. type/bug The issue is confirmed as a bug.

Comments

@AilinKid
Copy link
Contributor

AilinKid commented Dec 8, 2020

Bug Report

Please answer these questions before submitting your issue. Thanks!

Since multi-schema-change is not a feature of release-5.0, we add a variable to prevent side effects from the stability of v5.0.
So tics test should be aware of that and make the tests be compatible with this variable.

1. Minimal reproduce step (Required)

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_tics_test/detail/tidb_ghpr_tics_test/3240/pipeline

2. What did you expect to see? (Required)

Shouldn't be any literal character like Unsupported multi schema change

3. What did you see instead (Required)

Unsupported multi schema change

4. What is your TiDB version? (Required)

The variable is in tidb/pull/21533

@AilinKid AilinKid added the type/bug The issue is confirmed as a bug. label Dec 8, 2020
@AilinKid
Copy link
Contributor Author

AilinKid commented Dec 8, 2020

PTAL @JaySon-Huang

@AilinKid AilinKid changed the title tics: test should check set tidb_enable_change_multi_schema before changing multi schema tics: test should check tidb_enable_change_multi_schema before changing multi schema Dec 8, 2020
@AilinKid AilinKid closed this as completed Dec 8, 2020
@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

@AilinKid
Copy link
Contributor Author

AilinKid commented Dec 8, 2020

duplicated with pingcap/tiflash#1271

@AilinKid AilinKid added the duplicate Issues or pull requests already exists. label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues or pull requests already exists. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

2 participants