ddl: add a switch for multi schema change & make it compatible with old test cases #21533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st cases Signed-off-by: AilinKid <314806019@qq.com>
tangenta
reviewed
Dec 8, 2020
tangenta
reviewed
Dec 8, 2020
|
/run-all-tests |
|
/run-tics-test |
1 similar comment
|
/run-tics-test |
|
/run-unit-test |
|
/run-all-tests |
tangenta
reviewed
Dec 8, 2020
AilinKid
force-pushed
the
add_var_for_multi_schema_change
branch
from
26aae4a
to
4e87164
Compare
|
/run-all-tests |
tangenta
reviewed
Dec 9, 2020
sessionctx/variable/tidb_vars.go
Outdated
| @@ -560,6 +563,7 @@ const ( | |||
| DefTiDBDDLErrorCountLimit = 512 | |||
| DefTiDBMaxDeltaSchemaCount = 1024 | |||
| DefTiDBChangeColumnType = false | |||
| DefTiDBMultiSchemaChange = false | |||
There was a problem hiding this comment.
Suggested change
| DefTiDBMultiSchemaChange = false | |
| DefTiDBChangeMultiSchema = false |
|
/run-tics-test tics-test=pr/1272 |
Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: tangenta <tangenta@126.com>
ti-srebot
approved these changes
Dec 10, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AilinKid 314806019@qq.com
What problem does this PR solve?
Add a switch for multi schema change to make sure this feature won't affect release-5.0
What is changed and how it works?
Add a global variable for control whether it is supported for multi schema change.
Besides, there are huge tests (written with a common suite, not a serial suite), so adding a session variable setting for every test case is a burden for us. So I try to make the shortcut in the bootstrap stage of test storage. There is a referred case with
variable.TiDBPartitionPruneModefrom suli right above my code.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note