Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data race in executor_test #25013

Closed
Tracked by #25899
zhouqiang-cl opened this issue Jun 1, 2021 · 1 comment · Fixed by #26460
Closed
Tracked by #25899

data race in executor_test #25013

zhouqiang-cl opened this issue Jun 1, 2021 · 1 comment · Fixed by #26460
Assignees
Labels
affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@zhouqiang-cl
Copy link
Contributor

Bug Report

[2021-05-31T16:26:50.265Z] ==================
[2021-05-31T16:26:50.265Z] WARNING: DATA RACE
[2021-05-31T16:26:50.265Z] Write at 0x000007980360 by goroutine 481:
[2021-05-31T16:26:50.265Z]   github.com/pingcap/tidb/executor_test.(*testSuite1).testAnalyzeIncremental.func1()
[2021-05-31T16:26:50.265Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/analyze_test.go:614 +0xa4
[2021-05-31T16:26:50.265Z]   github.com/pingcap/tidb/executor_test.(*testSuite1).testAnalyzeIncremental()
[2021-05-31T16:26:50.265Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/analyze_test.go:664 +0x200f
[2021-05-31T16:26:50.265Z]   github.com/pingcap/tidb/executor_test.(*testSuite1).TestAnalyzeIncremental()
[2021-05-31T16:26:50.265Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/analyze_test.go:581 +0x114
[2021-05-31T16:26:50.265Z]   runtime.call16()
[2021-05-31T16:26:50.265Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-05-31T16:26:50.266Z]   reflect.Value.Call()
[2021-05-31T16:26:50.266Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-05-31T16:26:50.266Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-05-31T16:26:50.266Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-05-31T16:26:50.266Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-05-31T16:26:50.266Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-05-31T16:26:50.266Z] 
[2021-05-31T16:26:50.266Z] Previous read at 0x000007980360 by goroutine 374:
[2021-05-31T16:26:50.266Z]   github.com/pingcap/tidb/statistics/handle.(*SessionStatsCollector).StoreQueryFeedback()
[2021-05-31T16:26:50.266Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/handle/update.go:181 +0x224
[2021-05-31T16:26:50.266Z]   github.com/pingcap/tidb/session.(*session).StoreQueryFeedback()
[2021-05-31T16:26:50.266Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:391 +0x4f9
[2021-05-31T16:26:50.266Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startIndexWorker.func1()
[2021-05-31T16:26:50.266Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:573 +0xaa4
[2021-05-31T16:26:50.266Z] 
[2021-05-31T16:26:50.266Z] Goroutine 481 (running) created at:
[2021-05-31T16:26:50.266Z]   github.com/pingcap/check.(*suiteRunner).forkCall()
[2021-05-31T16:26:50.266Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:734 +0x4cc
[2021-05-31T16:26:50.266Z]   github.com/pingcap/check.(*suiteRunner).forkTest()
[2021-05-31T16:26:50.266Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:832 +0x1c4
[2021-05-31T16:26:50.266Z]   github.com/pingcap/check.(*suiteRunner).doRun()
[2021-05-31T16:26:50.266Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:666 +0x144
[2021-05-31T16:26:50.266Z]   github.com/pingcap/check.(*suiteRunner).asyncRun.func1()
[2021-05-31T16:26:50.266Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:650 +0x105
[2021-05-31T16:26:50.266Z] 
[2021-05-31T16:26:50.266Z] Goroutine 374 (finished) created at:
[2021-05-31T16:26:50.266Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startIndexWorker()
[2021-05-31T16:26:50.266Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:509 +0x504
[2021-05-31T16:26:50.266Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startWorkers()
[2021-05-31T16:26:50.266Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:463 +0x84
[2021-05-31T16:26:50.266Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Next()
[2021-05-31T16:26:50.266Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:663 +0x5e6
[2021-05-31T16:26:50.266Z]   github.com/pingcap/tidb/executor.Next()
[2021-05-31T16:26:50.266Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/executor.go:284 +0x2a8
[2021-05-31T16:26:50.266Z]   github.com/pingcap/tidb/executor.(*outerWorker).buildTask()
[2021-05-31T16:26:50.266Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_join.go:402 +0x77d
[2021-05-31T16:26:50.266Z]   github.com/pingcap/tidb/executor.(*outerWorker).run()
[2021-05-31T16:26:50.266Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_join.go:346 +0x15d
[2021-05-31T16:26:50.266Z] ==================

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/4133/pipeline/104

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master a80047c

@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants