Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: DBaaS lightning import doesn't fail if source folder not exist #28031

Closed
fubinzh opened this issue Sep 14, 2021 · 2 comments · Fixed by #30674
Closed

lightning: DBaaS lightning import doesn't fail if source folder not exist #28031

fubinzh opened this issue Sep 14, 2021 · 2 comments · Fixed by #30674
Assignees
@glorv
Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. component/lightning This issue is related to Lightning of TiDB. severity/major sig/migrate type/bug The issue is confirmed as a bug.

Comments

@fubinzh
Copy link

fubinzh commented Sep 14, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

From DBaaS, start a import task, specify a S3 folder which doesn't exists.

2. What did you expect to see? (Required)

Appropriate error should be displayed to user to let user know import failed.

3. What did you see instead (Required)

Lightning doesn't report error for the import. And go through all the import steps: schema create, precheck, etc.

dbaas_not_exist_folder

dbaas_not_exist_folder_2

4. What is your TiDB version? (Required)

Lightning: [release-version=v5.2.0] [git-hash=05d2210647d6a1503a8d772477e43b14a024f609]
@fubinzh fubinzh added type/bug The issue is confirmed as a bug. severity/major sig/migrate component/lightning This issue is related to Lightning of TiDB. labels Sep 14, 2021
@glorv glorv mentioned this issue Dec 13, 2021
Merged
12 tasks
@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

This was referenced Dec 14, 2021
Merged
Merged
@glorv glorv added affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. labels Dec 15, 2021
@glorv
Copy link
Contributor

glorv commented Dec 15, 2021

NOTE: this bug also affects tidb-lightning v4.0, v5.0 and v5.1.

ti-chi-bot pushed a commit that referenced this issue Feb 18, 2022
@ti-srebot
lightning: Add source dir existence check for s3 (#30674) (#30714)
82f51b7 
close #28031, close #30709
@guo-shaoge guo-shaoge mentioned this issue Feb 25, 2022
Merged
15 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 13, 2022
@ti-srebot
lightning: Add source dir existence check for s3 (#30674) (#30713)
998f38e 
close #28031, close #30709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glorv glorv

Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. component/lightning This issue is related to Lightning of TiDB. severity/major sig/migrate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: Add source dir existence check for s3 glorv/tidb
2 participants
@glorv @fubinzh