Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning: lightning_metadata not deleted after import exit successfully #28144

Closed
fubinzh opened this issue Sep 17, 2021 · 0 comments · Fixed by #28189
Closed

Lightning: lightning_metadata not deleted after import exit successfully #28144

fubinzh opened this issue Sep 17, 2021 · 0 comments · Fixed by #28189
Assignees
Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. component/lightning This issue is related to Lightning of TiDB. found/automation Found by automation tests severity/major sig/migrate type/bug The issue is confirmed as a bug.

Comments

@fubinzh
Copy link

fubinzh commented Sep 17, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  • Create a new tidb cluster
  • Enable tidb_enable_list_partition on Tidb
  • Import list partition test data (1.5k tables)
    data source: s3://nfs/tools_test_data/list_partition_1.5k?access-key=minioadmin&secret-access-key=minioadmin&endpoint=http%3a%2f%2fminio.pingcap.net%3a9000&force-path-style=true
  • After lightning import, check tidb whether lightning_metadata database was deleted.

2. What did you expect to see? (Required)

lightning_metadata database should be deleted.

3. What did you see instead (Required)

lightning_metadata not deleted through lightning import was successful.

Lightning log:
tidb lightning exit
2021-09-16T14:35:44.012Z INFO host/host.go:41 Execute command finished {"command": "/tidb-lightning "-tidb-port" "4000" "-tidb-user" "root" "-tidb-password" "" "-backend" "local" "-sorted-kv-dir" "/tmp/sorted-kv-dir" "-d" "s3://nfs/tools_test_data/list_partition_1.5k?access-key=minioadmin&secret-access-key=minioadmin&endpoint=http%3a%2f%2fminio.pingcap.net%3a9000&force-path-style=true" "-pd-urls" "upstream-pd.brie-acceptance-long-time-demo-9trtr.svc:2379" "-tidb-host" "upstream-tidb.brie-acceptance-
long-time-demo-9trtr.svc"", "execute duration": "37m33.076334571s"}

lightning_metadata

4. What is your TiDB version? (Required)

/ # ./tidb-lightning -V
Release Version: v5.2.0-nightly
Git Commit Hash: b839744
Git Branch: heads/refs/tags/v5.2.0-nightly
Go Version: go1.16.4
UTC Build Time: 2021-09-17 01:40:14
Race Enabled: false

@fubinzh fubinzh added type/bug The issue is confirmed as a bug. severity/major sig/migrate component/lightning This issue is related to Lightning of TiDB. labels Sep 17, 2021
@cyliu0 cyliu0 added the found/automation Found by automation tests label Sep 23, 2021
@jebter jebter added affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. labels Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. component/lightning This issue is related to Lightning of TiDB. found/automation Found by automation tests severity/major sig/migrate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants