Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning get stuck when check table empty failed #31797

Closed
glorv opened this issue Jan 19, 2022 · 0 comments · Fixed by #31798
Closed

lightning get stuck when check table empty failed #31797

glorv opened this issue Jan 19, 2022 · 0 comments · Fixed by #31798
Labels
affects-5.4 This bug affects 5.4.x versions. component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@glorv
Copy link
Contributor

glorv commented Jan 19, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Run tidb-lightning with 1k tables, there is a low probability that tidb-lightning will stuck.

From the go routine, I found it was stuck at

tidb/br/pkg/lightning/restore/check_info.go

Line 1132 in 7fd298d

ch <- common.UniqueTable(tbl.DB, tbl.Name)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@glorv glorv added type/bug The issue is confirmed as a bug. severity/major component/lightning This issue is related to Lightning of TiDB. labels Jan 19, 2022
@glorv glorv mentioned this issue Jan 19, 2022
Merged
12 tasks
@jebter jebter added affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. labels Jan 19, 2022
@glorv glorv removed the affects-5.3 This bug affects 5.3.x versions. label Feb 15, 2022
ti-chi-bot pushed a commit that referenced this issue Mar 16, 2022
@glorv
lightning: add retry and early terminate checking empty table (#31798)
a702ef1 
close #31797
@ti-srebot ti-srebot mentioned this issue Mar 16, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 21, 2022
@ti-srebot
lightning: add retry and early terminate checking empty table (#31798) (
c9b917b 
#33148)

close #31797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects 5.4.x versions. component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: add retry and early terminate checking empty table glorv/tidb
2 participants
@jebter @glorv