Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackupTS column of Restore Statement is not right in implementation #36142

Closed
IANTHEREAL opened this issue Jul 12, 2022 · 1 comment · Fixed by #36281
Closed

BackupTS column of Restore Statement is not right in implementation #36142

IANTHEREAL opened this issue Jul 12, 2022 · 1 comment · Fixed by #36281
Assignees
Labels
component/br This issue is related to BR of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@IANTHEREAL
Copy link
Contributor

IANTHEREAL commented Jul 12, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

In migrate data from one tidb to another tidb tourist

BackupTS column of Restore Statement is not right in implementation, in fact the value 431434141450371074is restored cluster ts, not backup ts

image

2. What did you expect to see? (Required)

Intuitively, backup ts should be the snapshot ts corresponding to the snapshot backup. So I suggest to refine the output schema. Take migrate data from one tidb to another tidb tourist as an example, it should be

mysql> RESTORE DATABASE * FROM 's3://backup?access-key=minio&secret-access-key=miniostorage&endpoint=http://${HOST_IP}:6060&force-path-style=true';

+------------+-----------+-------------------+-------------------+-------------+-------------+
| Backup Storage | Size   | BackupTS          |Cluster TS        |Queue Time   |Execution Time|
+---------- --+-----------+------------------+-------------------+-------------+-------------+
| s3://backup  | 10315858 |431434047157698561|431434141450371074| ***          | **          |
+------------+-----------+-------------------+-------------------+-------------+-------------+
1 row in set (41.85 sec)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

@IANTHEREAL IANTHEREAL added the type/bug The issue is confirmed as a bug. label Jul 12, 2022
@IANTHEREAL IANTHEREAL changed the title Restore Statement does not have a correctly implement for backup ts field Backupts field of Restore Statement is not right in implementation Jul 12, 2022
@IANTHEREAL IANTHEREAL changed the title Backupts field of Restore Statement is not right in implementation BackupTS column of Restore Statement is not right in implementation Jul 12, 2022
@seiya-annie seiya-annie added the component/br This issue is related to BR of TiDB. label Jul 14, 2022
@MoCuishle28
Copy link
Contributor

/assign MoCuishle28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants