Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable test TestStaleReadNoExtraTSORequest #42100

Closed
Tracked by #41316
tangenta opened this issue Mar 10, 2023 · 0 comments · Fixed by #42101
Closed
Tracked by #41316

Unstable test TestStaleReadNoExtraTSORequest #42100

tangenta opened this issue Mar 10, 2023 · 0 comments · Fixed by #42101
Labels
component/test severity/moderate type/enhancement The issue or PR belongs to an enhancement.

Comments

@tangenta
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Run unit test.

2. What did you expect to see? (Required)

No error.

3. What did you see instead (Required)

panic: tso shouldn't be requested [recovered]
	panic: tso shouldn't be requested

goroutine 538314 [running]:
github.com/pingcap/tidb/executor.(*Compiler).Compile.func1()
	executor/compiler.go:54 +0x477
panic({0x4e3b140, 0x5e78500})
	GOROOT/src/runtime/panic.go:884 +0x213
github.com/pingcap/tidb/session.(*session).PrepareTSFuture(0xc0a0aea000, {0x5eada50, 0xc0b17c29f0}, {0x5e88c40, 0xc0b17c2c90}, {0x5537555, 0x6})
	session/session.go:3715 +0x32c
github.com/pingcap/tidb/sessiontxn/isolation.(*baseTxnContextProvider).replaceTxnTsFuture(0xc0a09116f0, {0x5e88c40, 0xc0b17c2c90})
	sessiontxn/isolation/base.go:389 +0xcf
github.com/pingcap/tidb/sessiontxn/isolation.(*baseTxnContextProvider).prepareTxn(0xc0a09116f0)
	sessiontxn/isolation/base.go:354 +0xf5
github.com/pingcap/tidb/sessiontxn/isolation.(*baseTxnContextProvider).AdviseWarmup(0xc0a09116f0)
	sessiontxn/isolation/base.go:414 +0x90
github.com/pingcap/tidb/session.(*txnManager).AdviseWarmup(0x5f1d6f8?)
	session/txnmanager.go:318 +0x3d
github.com/pingcap/tidb/planner.Optimize({0x5eada50, 0xc0b17c29f0}, {0x5f1d6f8, 0xc0a0aea000}, {0x5ebdf20, 0xc0b17bcfc0}, {0x5ee2a50, 0xc0b17c2a80})
	planner/optimize.go:194 +0x7ff
github.com/pingcap/tidb/executor.(*Compiler).Compile(0xc0ae0894b8, {0x5eada50?, 0xc0b17c29f0?}, {0x5ec3380?, 0xc0b17bcfc0})
	executor/compiler.go:98 +0x5cc
github.com/pingcap/tidb/session.(*session).ExecuteStmt(0xc0a0aea000, {0x5eada50?, 0xc0b17c29f0?}, {0x5ec3380?, 0xc0b17bcfc0?})
	session/session.go:2140 +0x62c
github.com/pingcap/tidb/session.(*session).ExecuteInternal(0xc0a0aea000, {0x5eada50, 0xc0b17c29f0}, {0xc08590dee0, 0xcb}, {0x0, 0x0, 0x0})
	session/session.go:1628 +0x268
github.com/pingcap/tidb/ddl.(*session).execute(0xc0a0ab55c0, {0x5ead9e0, 0xc000234000}, {0xc08590dee0, 0xcb}, {0x5558733, 0xf})
	ddl/ddl.go:1639 +0x216
github.com/pingcap/tidb/ddl.(*ddl).getJob(0xc0a08a5600, 0xc0fad0899968fd40?, 0x160242afc1?, 0xc0ae089ae0)
	ddl/job_table.go:113 +0x175
github.com/pingcap/tidb/ddl.(*ddl).getGeneralJob(0xc0ae089b78?, 0x1?)
	ddl/job_table.go:143 +0x4f
github.com/pingcap/tidb/ddl.(*ddl).loadDDLJobAndRun(0xc0a08a5600, 0xc0ae089d30?, 0xc0a18ddf50, 0xc0ae089dc0)
	ddl/job_table.go:225 +0x139
github.com/pingcap/tidb/ddl.(*ddl).startDispatchLoop(0xc0a08a5600)
	ddl/job_table.go:209 +0x7d4
github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
	util/wait_group_wrapper.go:154 +0x6b
created by github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run
	util/wait_group_wrapper.go:152 +0x8d
--

4. What is your TiDB version? (Required)

0212c50

@tangenta tangenta added the type/bug The issue is confirmed as a bug. label Mar 10, 2023
@tangenta tangenta added component/test severity/minor type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. severity/minor labels Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test severity/moderate type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants