Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent reading records from different index when merging temp index #45847

Closed
tangenta opened this issue Aug 7, 2023 · 0 comments · Fixed by #54143
Closed

Prevent reading records from different index when merging temp index #45847

tangenta opened this issue Aug 7, 2023 · 0 comments · Fixed by #54143
Assignees
@tangenta
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@tangenta
Copy link
Contributor

tangenta commented Aug 7, 2023

Enhancement

From #45679 (comment):

tidb/ddl/backfilling.go

Line 549 in cf7ae4c

prefix = t.IndexPrefix()

t.IndexPrefix() is the key like t[tableID]_i. If we use t.IndexPrefix().PrefixNext() here, endKey will be t[tableID]_j?

As a result, we will scan the index records from all indexes.
@tangenta tangenta added the type/enhancement The issue or PR belongs to an enhancement. label Aug 7, 2023
@tangenta tangenta self-assigned this Aug 7, 2023
@tangenta tangenta mentioned this issue Jun 20, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in eec20e6 Jun 24, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Jul 30, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 5, 2024
@ti-chi-bot
ddl: skip getting actual end key for each range in ingest mode (#54143)…
e0ab246 
… (#55073)

close #45847, close #54147
@ti-chi-bot ti-chi-bot mentioned this issue Oct 21, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tangenta tangenta

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: skip getting actual end key for each range in ingest mode tangenta/tidb
1 participant
@tangenta