Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[global sort] can not add index with global sort concurrency #47758

Closed
aytrack opened this issue Oct 18, 2023 · 5 comments · Fixed by #48645
Closed

[global sort] can not add index with global sort concurrency #47758

aytrack opened this issue Oct 18, 2023 · 5 comments · Fixed by #48645
Labels
affects-7.5 component/ddl This issue is related to DDL of TiDB. report/customer Customers have encountered this bug. severity/major type/enhancement The issue or PR belongs to an enhancement.

Comments

@aytrack
Copy link
Contributor

aytrack commented Oct 18, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. enable global sort
  2. add index for 2 tables concurrenty

2. What did you expect to see? (Required)

  1. all running ddl jobs can use global sort add index

3. What did you see instead (Required)

  1. only 1 ddl job can use ingest model and global sort
  2. another add index job using txn merge

4. What is your TiDB version? (Required)

+-----------------------------------------------------------+
| tidb_version()                                            |
+-----------------------------------------------------------+
| Release Version: v7.5.0-alpha                             |
| Edition: Community                                        |
| Git Commit Hash: 79db4ec58be3856995d31013e20f3faa57e3a3ac |
| Git Branch: heads/refs/tags/v7.5.0-alpha                  |
| UTC Build Time: 2023-10-16 11:42:39                       |
| GoVersion: go1.21.3                                       |
| Race Enabled: false                                       |
| Check Table Before Drop: false                            |
| Store: tikv                                               |
+-----------------------------------------------------------+
@aytrack aytrack added type/bug The issue is confirmed as a bug. component/ddl This issue is related to DDL of TiDB. labels Oct 18, 2023
@aytrack aytrack changed the title [global sort] can not [global sort] can not add index with global sort concurrency Oct 18, 2023
@ywqzzy
Copy link
Contributor

ywqzzy commented Oct 19, 2023

For resource control and limit the resource that global sort consumed, we only allow one job running at the same time.
We will support running multiple jobs later.

@aytrack aytrack added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. labels Oct 19, 2023
@Benjamin2037
Copy link
Collaborator

We will remove this limitation in later version

@tangenta
Copy link
Contributor

TiDB cannot add index concurrently even after #48645.

@tangenta tangenta reopened this Nov 21, 2023
@tangenta tangenta added type/bug The issue is confirmed as a bug. severity/major affects-7.5 and removed type/enhancement The issue or PR belongs to an enhancement. labels Dec 15, 2023
@tangenta
Copy link
Contributor

In order to cherry-pick v7.5.1, change to severity/major bug.

@seiya-annie
Copy link

/found customer

@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Jun 4, 2024
@Benjamin2037 Benjamin2037 added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 component/ddl This issue is related to DDL of TiDB. report/customer Customers have encountered this bug. severity/major type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants