-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query returns incorrect result when context done in the middle #50089
Labels
affects-6.5
affects-7.1
affects-7.5
affects-7.6
affects-8.0
affects-8.1
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.1
severity/moderate
sig/execution
SIG execution
type/bug
The issue is confirmed as a bug.
Comments
ti-chi-bot
bot
added
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.1
may-affects-6.5
may-affects-7.1
may-affects-7.5
labels
Jan 5, 2024
No reproducible step for now, I'll change the label to severity/major. |
This was referenced Jan 30, 2024
Merged
13 tasks
this ut can reproduce it stablely, https://github.com/pingcap/tidb/pull/53489/files#diff-2e7a91a59b5e9ba8d14357364ef5aa423fc0ab5c7624bb4104e4c12c0bde3470R42 |
RidRisR
pushed a commit
to RidRisR/tidb
that referenced
this issue
May 27, 2024
… context cancel/timeout (pingcap#53489) close pingcap#50089
13 tasks
This was referenced Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-6.5
affects-7.1
affects-7.5
affects-7.6
affects-8.0
affects-8.1
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.1
severity/moderate
sig/execution
SIG execution
type/bug
The issue is confirmed as a bug.
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
suppose we have this patch added to help reproduce
then run this test
might need to run it for a few times
here we don't return context error, if context cancelled in the middle the query returns incorrect result.
Query from normal client don't have issue, as we don't cancel context except when kill where it's handled.
tidb/pkg/store/copr/coprocessor.go
Lines 945 to 951 in e8861cf
2. What did you expect to see? (Required)
got err: context deadline exceed
3. What did you see instead (Required)
no error, result set is empty
4. What is your TiDB version? (Required)
The text was updated successfully, but these errors were encountered: