Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global sort 120T test seekPropsOffsets performance problems #51639

Closed
lance6716 opened this issue Mar 11, 2024 · 0 comments · Fixed by #51676
Closed

global sort 120T test seekPropsOffsets performance problems #51639

lance6716 opened this issue Mar 11, 2024 · 0 comments · Fixed by #51676
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lance6716
Copy link
Contributor

Enhancement

When seekPropsOffsets need to handle 2800 files

[reader.go:43] [arguments] [data-file-count=2800] [stat-file-count=2800] [start-key=dIAAAAAAAABoX3IBNzAxMzk2ODj/OTFzSlFORW3/SzE4ckM0Nk//RVY1WFZzYTH/dDFZcGYwQVT/a1kAAAAAAAD5] [end-key=dIAAAAAAAABoX3IBNzAxNDEwOTf/N1ZmbVhBVTf/TENBUjlxYlP/Q1Z0ZjBIOWj/SlRWWU5uVm3/WgAAAAAAAAD4]

The single thread heap-based merge sort becomes bottleneck

image
image

as @wjhuang2016 suggested, we should find a more parallel way to handle it, like readAllData
@lance6716 lance6716 added the type/enhancement The issue or PR belongs to an enhancement. label Mar 11, 2024
@lance6716 lance6716 mentioned this issue Mar 12, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Mar 15, 2024
@lance6716
external: parallel seekPropsOffsets (#51676)
3ab313d 
close #51639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

external: parallel seekPropsOffsets lance6716/tidb
1 participant
@lance6716