Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EvalContext argument for Expression.GetType #53653

Closed
YangKeao opened this issue May 29, 2024 · 0 comments · Fixed by #53656
Closed

Add EvalContext argument for Expression.GetType #53653

YangKeao opened this issue May 29, 2024 · 0 comments · Fixed by #53656
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

Enhancement

Now, the Constant may rely on the internal session context to get the type of itself. It's not expected. It'd be better to add an argument EvalContext for Expression.GetType, and then we can read the param from it.
@YangKeao YangKeao added the type/enhancement The issue or PR belongs to an enhancement. label May 29, 2024
@YangKeao YangKeao mentioned this issue May 29, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 3, 2024
@YangKeao
expression, *: Eval param get type with context (#53656)
5e6df4e 
close #53653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expression, *: Eval param get type with context YangKeao/tidb
1 participant
@YangKeao