Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse memory for parallelSortSpillHelper‘s tmpSpillChunk #53861

Closed
Tracked by #52318
hawkingrei opened this issue Jun 6, 2024 · 0 comments · Fixed by #53859
Closed
Tracked by #52318

reuse memory for parallelSortSpillHelper‘s tmpSpillChunk #53861

hawkingrei opened this issue Jun 6, 2024 · 0 comments · Fixed by #53859
Labels
affects-8.1 type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

hawkingrei commented Jun 6, 2024 •
edited
Loading

Enhancement

we get a profiler while we benchmark sync load. it takes too much time on the newParallelSortSpillHelper. it is unnecessary.

https://flamegraph.com/share/4dca9137-2419-11ef-ab1b-b6898751f631

image
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label Jun 6, 2024
This was referenced Jun 6, 2024
Open
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 7, 2024
@hawkingrei
executor: reuse memory for parallelSortSpillHelper (#53859)
b9b5ec6 
close #53861
@ti-chi-bot ti-chi-bot mentioned this issue Jun 7, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot mentioned this issue Jun 8, 2024
Closed
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 8, 2024
@ti-chi-bot
executor: reuse memory for parallelSortSpillHelper (#53859) (#53879)
b7a6c25 
close #53861
@ti-chi-bot ti-chi-bot mentioned this issue Jun 8, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.1 type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: reuse memory for parallelSortSpillHelper hawkingrei/tidb
2 participants
@hawkingrei @ti-chi-bot