Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove useless strings.ToLower in the (*Explain).RenderResult #53896

Closed
hawkingrei opened this issue Jun 9, 2024 · 0 comments · Fixed by #53897
Closed

remove useless strings.ToLower in the (*Explain).RenderResult #53896

hawkingrei opened this issue Jun 9, 2024 · 0 comments · Fixed by #53897
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

hawkingrei commented Jun 9, 2024 •
edited
Loading

Enhancement

remove useless strings.ToLower in the (*Explain).RenderResult. although it is very small. it still can be found in the pprof.

image

https://flamegraph.com/share/ce8f8cd2-2654-11ef-aba3-6a3d1814cbe4
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label Jun 9, 2024
@hawkingrei hawkingrei mentioned this issue Jun 9, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 11, 2024
@hawkingrei
planner: remove useless string.ToLower in the Explain (#53897)
d3dd254 
close #53896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner: remove useless string.ToLower in the Explain hawkingrei/tidb
1 participant
@hawkingrei