Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save unnecessary RuneCountInString #53942

Closed
ekexium opened this issue Jun 11, 2024 · 0 comments · Fixed by #53941
Closed

Save unnecessary RuneCountInString #53942

ekexium opened this issue Jun 11, 2024 · 0 comments · Fixed by #53941
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@ekexium
Copy link
Contributor

ekexium commented Jun 11, 2024

Enhancement

RuneCountInString can be unexpectedly time-consuming for certain workloads. Since the number of runes must be smaller than or equal to the length of the string, we can fast check the length first. Only calculate the number of runes when necessary.
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

datum: check len(s) before calculating and checking runeCount ekexium/tidb
1 participant
@ekexium