Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datum: check len(s) before calculating and checking runeCount #53941

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Jun 11, 2024

What problem does this PR solve?

Issue Number: close #53942

Problem Summary:

RuneCountInString can be unexpectedly time-consuming for certain workloads. Since the number of runes must be smaller than or equal to the length of the string, we can fast check the length first. Only calculate the number of runes when necessary.

Before:

go test -run=^$ -bench=BenchmarkInsertIntoSelect -benchmem -benchtime=100x
     100	 136332696 ns/op	106229159 B/op	  507278 allocs/op

This PR:

go test -run=^$ -bench=BenchmarkInsertIntoSelect -benchmem -benchtime=100x
     100	 123812334 ns/op	106041608 B/op	  506652 allocs/op

What changed and how does it work?

Check List

Tests

  • Unit test: already covered by existing cases and benchmarks
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2024
Copy link

tiprow bot commented Jun 11, 2024

Hi @ekexium. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.8063%. Comparing base (a865c86) to head (f3e03bf).
Report is 20 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53941         +/-   ##
=================================================
- Coverage   72.6206%   55.8063%   -16.8144%     
=================================================
  Files          1507       1628        +121     
  Lines        431669     603639     +171970     
=================================================
+ Hits         313481     336869      +23388     
- Misses        98878     243593     +144715     
- Partials      19310      23177       +3867     
Flag Coverage Δ
integration 37.1702% <79.3103%> (?)
unit 71.4500% <75.8620%> (-0.1592%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4460% <ø> (+8.2959%) ⬆️

pkg/types/datum.go Outdated Show resolved Hide resolved
@cfzjywxk cfzjywxk requested review from zyguan and you06 June 12, 2024 08:40
Signed-off-by: ekexium <eke@fastmail.com>
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2024
Copy link

ti-chi-bot bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2024
Copy link

ti-chi-bot bot commented Jun 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-13 01:43:51.40513252 +0000 UTC m=+601785.458444444: ☑️ agreed by cfzjywxk.
  • 2024-06-13 03:29:20.856604816 +0000 UTC m=+608114.909916737: ☑️ agreed by zyguan.

@ti-chi-bot ti-chi-bot bot merged commit fab0940 into pingcap:master Jun 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save unnecessary RuneCountInString
3 participants