Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seems writeBufs.IndexValsBuf in TableCommon.addIndices is not reused. #54698

Closed
lcwangchao opened this issue Jul 18, 2024 · 1 comment · Fixed by #54699
Closed

seems writeBufs.IndexValsBuf in TableCommon.addIndices is not reused. #54698

lcwangchao opened this issue Jul 18, 2024 · 1 comment · Fixed by #54699
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Jul 18, 2024 •
edited
Loading

Enhancement

See:

tidb/pkg/table/tables/tables.go

Line 1109 in a48a4a2

indexVals, err := v.FetchValues(r, indexVals)

The indexVals is assigned using := that makes it a new variable and shadows the outside declaration.

image

writeBufs.IndexValsBuf is always nil and the []types.Datum will be allocated every time.
@lcwangchao lcwangchao added the type/enhancement The issue or PR belongs to an enhancement. label Jul 18, 2024
@lcwangchao
Copy link
Collaborator Author

It is introduced by #18372 when refactoring code.

@lcwangchao lcwangchao mentioned this issue Jul 18, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 18, 2024
@lcwangchao
tables: fix invalid reuse of indexVals in addIndices (#54699)
4450f0e 
close #54698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tables: fix invalid reuse of indexVals in addIndices lcwangchao/tidb
1 participant
@lcwangchao