Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning logical mode import should support persistent connection pooling and prepared statement and client statement cache #54850

Closed
dbsid opened this issue Jul 23, 2024 · 0 comments · Fixed by #55482
Closed

lightning logical mode import should support persistent connection pooling and prepared statement and client statement cache #54850

dbsid opened this issue Jul 23, 2024 · 0 comments · Fixed by #55482
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@dbsid
Copy link
Contributor

dbsid commented Jul 23, 2024

Enhancement

during the tidb mode import, seems lightning destroy the connection after the insert, making it impossible to reuse the connection and plan cache hit.

image

high overhead on sql parse and compile
image
@dbsid dbsid added the type/enhancement The issue or PR belongs to an enhancement. label Jul 23, 2024
@dbsid dbsid mentioned this issue Jul 23, 2024
Closed
13 tasks
@dbsid dbsid changed the title lightning logical mode import should support persistent connection pooling lightning logical mode import should support persistent connection pooling and prepared statement and client statement cache Jul 27, 2024
@dbsid dbsid mentioned this issue Jul 27, 2024
Draft
13 tasks
This was referenced Aug 16, 2024
Closed
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in 2eb4dc8 Sep 21, 2024
winoros pushed a commit to winoros/tidb that referenced this issue Sep 23, 2024
@dbsid @winoros
lightning: support prepared statement and client stmt cache in logica…
5de9091 
…l import mode (pingcap#55482)

close pingcap#54850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
1 participant
@dbsid