-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning's internal table does not have PK so can't work with sql_require_primary_key=ON #57479
Labels
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-8.5
This bug affects the 8.5.x(LTS) versions.
severity/moderate
type/bug
The issue is confirmed as a bug.
Comments
13 tasks
does DM have this issue? |
Yes we should also upgrade lightning dependency for DM |
I mean does any DM's internal table has no PK? |
DM internal tables also need to add PK, like |
forget to change the VIEW name, reopen. |
seems no need to change VIEW name, because we use CREATE OR REPLACE VIEW |
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-6.5
This bug affects the 6.5.x(LTS) versions.
affects-8.5
This bug affects the 8.5.x(LTS) versions.
severity/moderate
type/bug
The issue is confirmed as a bug.
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
turn on
sql_require_primary_key
and run lightning2. What did you expect to see? (Required)
no error
3. What did you see instead (Required)
lightning will create some internal tables, and failed with error
Unable to create or change a table without a primary key, when the system variable 'sql_require_primary_key' is set. Add a primary key to the table or unset this variable to avoid this message. Note that tables without a primary key can cause performance problems in row-based replication, so please consult your DBA before changing this setting.
This is because these tables have no PK4. What is your TiDB version? (Required)
all version
The text was updated successfully, but these errors were encountered: