Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: addition between datetime and real interval is not compatible with Mysql #10347

Merged
merged 1 commit into from
May 9, 2019

Conversation

erjiaqing
Copy link
Contributor

What problem does this PR solve?

Fix #10346

What is changed and how it works?

Add builtin{Add|Sub}Date{Datetime|String|Int}RealSig to support float type intervals.

Check List

Tests

  • Integration test

@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #10347 into master will decrease coverage by 0.0379%.
The diff coverage is 51.1811%.

@@               Coverage Diff               @@
##             master     #10347       +/-   ##
===============================================
- Coverage   77.6755%   77.6375%   -0.038%     
===============================================
  Files           411        411               
  Lines         85440      85514       +74     
===============================================
+ Hits          66366      66391       +25     
- Misses        14113      14142       +29     
- Partials       4961       4981       +20

@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #10347 into master will decrease coverage by 0.045%.
The diff coverage is 51.1811%.

@@               Coverage Diff                @@
##             master     #10347        +/-   ##
================================================
- Coverage   77.3733%   77.3282%   -0.0451%     
================================================
  Files           412        412                
  Lines         85722      85847       +125     
================================================
+ Hits          66326      66384        +58     
- Misses        14370      14412        +42     
- Partials       5026       5051        +25

@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label May 8, 2019
@qw4990 qw4990 requested review from qw4990 and winoros May 8, 2019 05:31
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 requested review from eurekaka, alivxxx and winoros and removed request for winoros May 8, 2019 05:51
alivxxx
alivxxx previously approved these changes May 9, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT2 Indicates that a PR has LGTM 2. label May 9, 2019
@alivxxx
Copy link
Contributor

alivxxx commented May 9, 2019

/run-all-tests

1 similar comment
@cwen0
Copy link
Member

cwen0 commented May 9, 2019

/run-all-tests

@cwen0
Copy link
Member

cwen0 commented May 9, 2019

/rebuild

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented May 9, 2019

/rebuild

@erjiaqing
Copy link
Contributor Author

/run-all-tests

@qw4990 qw4990 merged commit c2e83af into pingcap:master May 9, 2019
@erjiaqing erjiaqing deleted the issue_10346 branch May 9, 2019 08:56
erjiaqing added a commit to erjiaqing/tidb that referenced this pull request May 10, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addition between datetime and real interval is not compatible with Mysql
5 participants