Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add some logs about boostrap #10546

Merged
merged 5 commits into from
May 27, 2019
Merged

*: add some logs about boostrap #10546

merged 5 commits into from
May 27, 2019

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Bootstrap related logs are relatively few.

What is changed and how it works?

Add some logs about bootstrap
Unify close component logs

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

@zimulala zimulala added the type/enhancement The issue or PR belongs to an enhancement. label May 20, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c4db7b7). Click here to learn what that means.
The diff coverage is 55.5555%.

@@             Coverage Diff             @@
##             master     #10546   +/-   ##
===========================================
  Coverage          ?   77.3765%           
===========================================
  Files             ?        413           
  Lines             ?      87489           
  Branches          ?          0           
===========================================
  Hits              ?      67696           
  Misses            ?      14585           
  Partials          ?       5208

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented May 23, 2019

/run-all-tests

@ngaut ngaut merged commit d3a750c into pingcap:master May 27, 2019
db-storage pushed a commit to db-storage/tidb that referenced this pull request May 29, 2019
@zimulala zimulala deleted the update_log branch May 30, 2019 08:42
zimulala added a commit to zimulala/tidb that referenced this pull request May 31, 2019
zimulala added a commit to zimulala/tidb that referenced this pull request May 31, 2019
zimulala added a commit that referenced this pull request May 31, 2019
zimulala added a commit that referenced this pull request May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants