-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: skip virtual generated column in analyze push down #10623
Conversation
Add test? |
Codecov Report
@@ Coverage Diff @@
## master #10623 +/- ##
================================================
- Coverage 77.7226% 77.6962% -0.0265%
================================================
Files 413 413
Lines 87515 87465 -50
================================================
- Hits 68019 67957 -62
- Misses 14351 14361 +10
- Partials 5145 5147 +2 |
Codecov Report
@@ Coverage Diff @@
## master #10623 +/- ##
================================================
+ Coverage 77.7126% 77.7381% +0.0254%
================================================
Files 413 413
Lines 87507 87468 -39
================================================
- Hits 68004 67996 -8
+ Misses 14355 14332 -23
+ Partials 5148 5140 -8 |
Signed-off-by: Lonng <heng@lonng.org>
/run-all-tests tidb-test=pr/827 |
/run-integration-common-test tidb-test=pr/827 |
/run-integration-common-test tidb-test=pr/827 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…0623) Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
The virtual column will not store any data in TiKV, so it should be ignored in analyze.
What is changed and how it works?
Filter virtual generated column when push down analyze.
Check List
Tests
Unit test
Integration test
Manually test
Before fix:
After fix:
Related changes