-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix show create table for partitioned table #10682
Conversation
Show create table result for create table ... auto_increment = xx partition by ... should not be create table ... partition by ... auto_increment = xx
Codecov Report
@@ Coverage Diff @@
## master #10682 +/- ##
================================================
+ Coverage 78.3419% 78.3437% +0.0018%
================================================
Files 414 414
Lines 87704 87656 -48
================================================
- Hits 68709 68673 -36
+ Misses 13852 13845 -7
+ Partials 5143 5138 -5 |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The description is not clear. You not only handle the |
@shenli Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Show create table result:
AUTO_INCREMENT=505488
should not be after PARTITION definitions.If there is a
COMMENT=xxx
, it would meet the same problem asAUTO_INCREMENT=xxx
.What is changed and how it works?
Fix the order, let the PARTITION definitions come last
Check List
Tests
Related changes