-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix issue that function dayname
is incompatible with Mysql when doing arithmetic(#9975)
#10732
Conversation
/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
dayname
is incompatible with Mysql when doing arithmeticdayname
is incompatible with Mysql when doing arithmetic(#9975)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@qw4990 Please resolve conflicts |
/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
@zz-jason fixed. |
…sql when doing arithmetic (pingcap#9975)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry-pick for #9975