-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: refine text protocol multiple query response #11263
Conversation
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11263 +/- ##
===========================================
Coverage 81.5609% 81.5609%
===========================================
Files 423 423
Lines 91301 91301
===========================================
Hits 74466 74466
Misses 11512 11512
Partials 5323 5323 |
/run-all-tests tidb-test=pr/859 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests tidb-test=pr/859 |
@lysu does it need to be cherry-picked to release-3.0? |
What problem does this PR solve?
fixes #11235
the current multi-query response has some problem
in tidb:
in mysql:
tidb will return
-1, -1, 0
, but mysql need-1, -1
.this PR fix both problems, but leave #4617 to next (because it need change too many code)
What is changed and how it works?
ServerMoreResultsExists
set logicwriteMultiResultset
Check List
Tests
Code changes
Side effects
Related changes