expression: make builtinCastIntAsInt support vectorized evaluation
#11826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
force-pushed
the
vecexpr-func-castIntAsInt4
branch
from
a29c115
to
911f3c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #11826 +/- ##
================================================
- Coverage 81.3093% 81.2461% -0.0633%
================================================
Files 438 438
Lines 94566 94455 -111
================================================
- Hits 76891 76741 -150
- Misses 12208 12238 +30
- Partials 5467 5476 +9 |
qw4990
commented
Aug 22, 2019
qw4990
force-pushed
the
vecexpr-func-castIntAsInt4
branch
from
bd3edd6
to
78b9b0f
Compare
qw4990
force-pushed
the
vecexpr-func-castIntAsInt4
branch
from
f9b4ee3
to
a14346c
Compare
XuHuaiyu
reviewed
Aug 23, 2019
|
/run-all-tests |
|
/run-common-test |
|
/run-all-tests |
XuHuaiyu
added
status/LGT2
|
/run-common-test |
|
/run-all-tests |
qw4990
force-pushed
the
vecexpr-func-castIntAsInt4
branch
from
fd3767e
to
5c7178a
Compare
|
/run-all-tests |
qw4990
force-pushed
the
vecexpr-func-castIntAsInt4
branch
from
fd66d70
to
408b85f
Compare
|
/run-common-test |
zz-jason
reviewed
Aug 24, 2019
| "github.com/pingcap/tidb/util/mock" | ||
| ) | ||
|
|
||
| func BenchmarkCastIntAsInt(b *testing.B) { |
There was a problem hiding this comment.
could you post the benchmark code on the old cast implementation?
There was a problem hiding this comment.
Try to use https://godoc.org/golang.org/x/perf/cmd/benchstat and post the benchmark result in the pull request description
There was a problem hiding this comment.
It is implemented here (https://github.com/pingcap/tidb/pull/11826/files#diff-2967d2754f43b7d6318020f0953a69f3R38)
SunRunAway
reviewed
Aug 26, 2019
|
/run-all-tests |
qw4990
force-pushed
the
vecexpr-func-castIntAsInt4
branch
from
e7e4b0a
to
237c4fb
Compare
zz-jason
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for
builtinCastIntAsInt.What is changed and how it works?
Here is the benchmark in my MAC, almost 95x faster than before:
Check List
Tests