Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: don't prune sleep function in LogicalProjection #11927

Merged
merged 3 commits into from
Aug 30, 2019

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Aug 29, 2019

What problem does this PR solve?

Fix #11905

What is changed and how it works?

Don't prune sleep function in LogicalProjection

Check List

Tests

  • explain test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Write release note for bug-fix or new feature.

@wjhuang2016 wjhuang2016 changed the title expression: don't prune sleep function in LogicalProjection planner: don't prune sleep function in LogicalProjection Aug 29, 2019
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #11927 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11927   +/-   ##
===========================================
  Coverage   81.2092%   81.2092%           
===========================================
  Files           443        443           
  Lines         95015      95015           
===========================================
  Hits          77161      77161           
  Misses        12353      12353           
  Partials       5501       5501

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 30, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 30, 2019

cherry pick to release-3.0 in PR #11953

@sre-bot
Copy link
Contributor

sre-bot commented Aug 30, 2019

cherry pick to release-2.1 failed

@cyliu0
Copy link
Contributor

cyliu0 commented Nov 6, 2019

@wjhuang2016 Do we need to cherry pick this one to release-3.1?

@wjhuang2016
Copy link
Member Author

@wjhuang2016 Do we need to cherry pick this one to release-3.1?

Yeah, I will cherry-pick it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected results caused by column pruning rules
5 participants