Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: support display invalid key in stats buckets (#12064) #12098

Merged
merged 2 commits into from
Sep 10, 2019
Merged

stats: support display invalid key in stats buckets (#12064) #12098

merged 2 commits into from
Sep 10, 2019
+24 −12

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Sep 9, 2019

Cherry pick #12064

zz-jason
zz-jason reviewed Sep 9, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2019
lzmhhh123
lzmhhh123 approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alivxxx
Copy link
Contributor Author

alivxxx commented Sep 10, 2019

/run-all-tests

winoros
winoros reviewed Sep 10, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 10, 2019

/run-all-tests

@sre-bot sre-bot merged commit 0b82541 into pingcap:release-2.1 Sep 10, 2019
@alivxxx alivxxx deleted the invalid-key branch September 12, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@winoros winoros winoros left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Assignees
No one assigned
Labels
component/statistics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alivxxx @sre-bot @zz-jason @winoros @lzmhhh123