ddl: disallow dropping auto_increment column attribute #12107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12107 +/- ##
=========================================
Coverage 81.322% 81.322%
=========================================
Files 451 451
Lines 96606 96606
=========================================
Hits 78562 78562
Misses 12410 12410
Partials 5634 5634 |
bb7133
reviewed
Sep 10, 2019
crazycs520
reviewed
Sep 10, 2019
|
/run-all-tests |
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Sep 11, 2019
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Sep 11, 2019
zz-jason
pushed a commit
that referenced
this pull request
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Disallow dropping auto_increment column attribute
What is changed and how it works?
Tweak the check in
getModifiableColumnJob.Check List
Tests
Code changes
Side effects
Related changes
Release note