-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement vectorized evaluation for builtinSqrtSig #12187
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12187 +/- ##
===============================================
- Coverage 81.579% 81.1832% -0.3959%
===============================================
Files 454 454
Lines 99425 97987 -1438
===============================================
- Hits 81110 79549 -1561
- Misses 12607 12712 +105
- Partials 5708 5726 +18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! @jacklightChen Please update your branch to the latest version and try it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@jacklightChen merge failed. |
What problem does this PR solve?
implement vectorized evaluation for builtinSqrtSig, for #12105
What is changed and how it works?
according to benchmark, about 5 times faster than before:
ps:if we don't check
result.IsNull(i)
in the loop,the method is only 3 times faster than before, so it's better to add those check nulls codes:Check List
Tests