expression: implement vectorized evaluation for builtinAtan2ArgsSig #12228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expression: implement vectorized evaluation for builtinAsinSig (pingcap#12222)
zz-jason
reviewed
Sep 17, 2019
expression/builtin_math_vec.go
Outdated
| return err | ||
| } | ||
|
|
||
| result.ResizeFloat64(n, false) |
There was a problem hiding this comment.
we can use the result variable to store one of it's parameter's result. Thus the vectors used in the calculation can be reduced from 3 to 2.
Codecov Report
@@ Coverage Diff @@
## master #12228 +/- ##
===============================================
- Coverage 81.225% 81.0943% -0.1307%
===============================================
Files 454 454
Lines 99260 98447 -813
===============================================
- Hits 80624 79835 -789
+ Misses 12864 12850 -14
+ Partials 5772 5762 -10 |
Reminiscent
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 12227 |
|
/run-all-tests |
|
@jacklightChen merge failed. |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for builtinAtan2ArgsSig, for #12105
What is changed and how it works?
according to benchmark, about 3 times faster than before:
Check List
Tests