expression: implement vectorized evaluation for builtinCosSig #12229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expression: implement vectorized evaluation for builtinAsinSig (pingcap#12222)
Codecov Report
@@ Coverage Diff @@
## master #12229 +/- ##
===========================================
Coverage 80.9825% 80.9825%
===========================================
Files 454 454
Lines 98462 98462
===========================================
Hits 79737 79737
Misses 12984 12984
Partials 5741 5741 |
zz-jason
reviewed
Sep 17, 2019
zz-jason
approved these changes
Sep 17, 2019
zz-jason
added
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for builtinCosSig, for #12105
What is changed and how it works?
according to benchmark, about 2 times faster than before:
Check List
Tests