Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinCotSig #12231

Merged
merged 9 commits into from
Sep 18, 2019
Merged

expression: implement vectorized evaluation for builtinCotSig #12231

merged 9 commits into from
Sep 18, 2019

Conversation

jacklightChen
Copy link
Contributor

What problem does this PR solve?

implement vectorized evaluation for builtinCotSig, for #12105

What is changed and how it works?

according to benchmark, about 2 times faster than before:

BenchmarkVectorizedBuiltinMathFunc/builtinCotSig-VecBuiltinFunc-8                 100000             18590 ns/op            0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinCotSig-NonVecBuiltinFunc-8               50000             42268 ns/op            0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 17, 2019
@codecov
Copy link

codecov bot commented Sep 17, 2019 •
edited
Loading

Codecov Report

Merging #12231 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12231   +/-   ##
===========================================
  Coverage   81.1128%   81.1128%           
===========================================
  Files           454        454           
  Lines         98808      98808           
===========================================
  Hits          80146      80146           
  Misses        12883      12883           
  Partials       5779       5779

zz-jason
zz-jason reviewed Sep 17, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
please merge master branch and resolve conflicts.

@zz-jason zz-jason added component/expression status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2019
@jacklightChen
Copy link
Contributor Author

/run-unit-test

Reminiscent
Reminiscent reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reminiscent
Reminiscent previously approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please the resolve conflicts

@Reminiscent Reminiscent removed the request for review from qw4990 September 18, 2019 02:52
@Reminiscent Reminiscent added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

Your auto merge job has been accepted, waiting for 12153

@zz-jason zz-jason merged commit f4a3bc5 into pingcap:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacklightChen @sre-bot @zz-jason @Reminiscent