Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinDegreesSig #12234

Merged
merged 8 commits into from
Sep 18, 2019
Merged

expression: implement vectorized evaluation for builtinDegreesSig #12234

merged 8 commits into from
Sep 18, 2019

Conversation

jacklightChen
Copy link
Contributor

What problem does this PR solve?

implement vectorized evaluation for builtinDegreesSig, for #12105

What is changed and how it works?

according to benchmark, about 10 times faster than before:

BenchmarkVectorizedBuiltinMathFunc/builtinDegreesSig-VecBuiltinFunc-8            1000000              1972 ns/op            0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinDegreesSig-NonVecBuiltinFunc-8          100000             15049 ns/op            0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 17, 2019
@codecov
Copy link

codecov bot commented Sep 17, 2019 •
edited
Loading

Codecov Report

Merging #12234 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12234   +/-   ##
===========================================
  Coverage   81.0744%   81.0744%           
===========================================
  Files           454        454           
  Lines         98655      98655           
===========================================
  Hits          79984      79984           
  Misses        12897      12897           
  Partials       5774       5774

zz-jason
zz-jason reviewed Sep 18, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/expression status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2019
XuHuaiyu
XuHuaiyu previously approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2019
@Reminiscent Reminiscent added the status/can-merge Indicates a PR has been approved by a committer. label Sep 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

@jacklightChen merge failed.

@jacklightChen
Copy link
Contributor Author

/run-unit-test

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

Your auto merge job has been accepted, waiting for 12249

@sre-bot
Copy link
Contributor

sre-bot commented Sep 18, 2019

/run-all-tests

@zz-jason zz-jason merged commit c6b842c into pingcap:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jacklightChen @sre-bot @zz-jason @XuHuaiyu @Reminiscent