Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix a bug of FromGoTime when handling rounding #12259

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #12240

PTAL @lysu @zz-jason

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from lysu September 18, 2019 13:46
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Sep 24, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 24, 2019

Your auto merge job has been accepted, waiting for 12314, 12258

@sre-bot
Copy link
Contributor

sre-bot commented Sep 24, 2019

/run-all-tests

@sre-bot sre-bot merged commit 3f94f57 into pingcap:release-2.1 Sep 24, 2019
@tiancaiamao tiancaiamao deleted the from-go-time-2.1 branch October 9, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/util status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants