Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinRoundWithFracRealSig #12275

Merged
merged 7 commits into from
Sep 25, 2019
Merged

expression: implement vectorized evaluation for builtinRoundWithFracRealSig #12275

merged 7 commits into from
Sep 25, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Sep 19, 2019 •
edited by qw4990
Loading

What problem does this PR solve?

implement vectorized evaluation for builtinRoundWithFracRealSig , for #12105

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinMathFunc/builtinRoundWithFracRealSig-VecBuiltinFunc-8         	  200000	      9039 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinRoundWithFracRealSig-NonVecBuiltinFunc-8      	   50000	     38640 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 19, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019 •
edited
Loading

Codecov Report

Merging #12275 into master will decrease coverage by 0.0324%.
The diff coverage is 60%.

@@               Coverage Diff                @@
##             master     #12275        +/-   ##
================================================
- Coverage   80.8356%   80.8031%   -0.0325%     
================================================
  Files           454        454                
  Lines         99330      99282        -48     
================================================
- Hits          80294      80223        -71     
- Misses        13257      13273        +16     
- Partials       5779       5786         +7

qw4990
qw4990 reviewed Sep 22, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reminiscent
Reminiscent previously approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 23, 2019
@Reminiscent
Copy link
Contributor

@tsthght Please resolve the conflict, Thanks.

zz-jason
zz-jason approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@sre-bot sre-bot merged commit 4686eca into pingcap:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@zz-jason zz-jason zz-jason approved these changes

@Reminiscent Reminiscent Reminiscent left review comments

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tsthght @Reminiscent @zz-jason @sre-bot @qw4990 @Hokkaitao