Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for builtinCastRealAsRealSig #12280

Conversation

hellojujian
Copy link
Contributor

What problem does this PR solve?

implement vectorized evaluation for builtinCastRealAsRealSig, for #12105

What is changed and how it works?

according to benchmark, about 10 times faster than before:

BenchmarkVectorizedBuiltinCastFunc/builtinCastRealAsRealSig-VecBuiltinFunc-8       	 1000000	      1826 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastRealAsRealSig-NonVecBuiltinFunc-8    	  100000	     20722 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 19, 2019
@CLAassistant
Copy link

CLAassistant commented Sep 19, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hellojujian
❌ jujian


jujian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hellojujian hellojujian changed the title feat(cast): add vecEvalReal to builtinCastRealAsRealSig expression: implement vectorized evaluation for builtinCastRealAsRealSig Sep 19, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #12280 into master will decrease coverage by 0.1224%.
The diff coverage is 85.7142%.

@@               Coverage Diff                @@
##             master     #12280        +/-   ##
================================================
- Coverage   81.2062%   81.0837%   -0.1225%     
================================================
  Files           454        454                
  Lines         99448      98672       -776     
================================================
- Hits          80758      80007       -751     
  Misses        12894      12894                
+ Partials       5796       5771        -25

@hellojujian
Copy link
Contributor Author

wrong git config failed CLA check :(
close and create a new PR

@hellojujian hellojujian deleted the implement_builtin_cast_real2real_vec branch September 22, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants