Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinRoundIntSig #12298

Merged
merged 2 commits into from
Sep 23, 2019
Merged

expression: implement vectorized evaluation for builtinRoundIntSig #12298

merged 2 commits into from
Sep 23, 2019

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Sep 22, 2019 •
edited
Loading

What problem does this PR solve?

Implement vectorized evaluation for builtinRoundIntSig.
Issue: #12103

What is changed and how it works?

BenchmarkVectorizedBuiltinMathFunc/builtinRoundIntSig-VecBuiltinFunc-4          20000000               107 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinRoundIntSig-NonVecBuiltinFunc-4         100000             19785 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 22, 2019
@tangwz tangwz changed the title expression: implement vectorized evaluation for builtinRoundIntSig(#1… expression: implement vectorized evaluation for builtinRoundIntSig Sep 22, 2019
Reminiscent
Reminiscent reviewed Sep 23, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2019
qw4990
qw4990 approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 23, 2019

Your auto merge job has been accepted, waiting for 12299

@sre-bot
Copy link
Contributor

sre-bot commented Sep 23, 2019

/run-all-tests

@sre-bot sre-bot merged commit 61f26d8 into pingcap:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@qw4990 qw4990 qw4990 approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangwz @sre-bot @qw4990 @Reminiscent @zz-jason