planner/core: do not change window ast when building plan #12347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12347 +/- ##
===========================================
Coverage 79.6921% 79.6921%
===========================================
Files 461 461
Lines 101621 101621
===========================================
Hits 80984 80984
Misses 14813 14813
Partials 5824 5824 |
alivxxx
added
status/can-merge
|
/run-all-tests |
XuHuaiyu
pushed a commit
to XuHuaiyu/tidb
that referenced
this pull request
Oct 25, 2019
XuHuaiyu
pushed a commit
to XuHuaiyu/tidb
that referenced
this pull request
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Do not change the window spec field when building window functions, as there is a special field
OnlyAliasthat affects restore, it should not be overwritten.What is changed and how it works?
Do not change the window expr.
Check List
Tests
Unit test
Code changes
Has exported function/method change
Side effects
Related changes
Release note